akanyan/mu3-mods
akanyan/mu3-mods
2
4
Fork 1
Code Issues 3 Pull Requests Releases 15 Wiki Activity

AttractVideoPlayer #2

Merged
akanyan merged 3 commits from jujuforce/mu3-mods:AttractVideoPlayer into main 2024-07-22 14:55:54 +00:00
Conversation 2 Commits 3 Files Changed 5 +113
jujuforce commented 2024-07-21 19:31:40 +00:00
Contributor
Copy Link

Service Button : Pause the attract video
L2/L3 Buttons : Previous/next to cycle through all the attract videos
Saving the selected video for future game launches

Service Button : Pause the attract video L2/L3 Buttons : Previous/next to cycle through all the attract videos Saving the selected video for future game launches
jujuforce added 6 commits 2024-07-21 19:31:41 +00:00 
# Conflicts:
#	MiscMods.sln
#	UnlockAndSetJewelBoostNine/MU3/patch_Scene_32_PrePlayMusic_Confirm.cs
- Service Button : Pause the attract video
- L2/L3 Buttons : Previous/next to cycle through all the attract videos
- Saving the selected video for future game launches
akanyan commented 2024-07-21 23:58:53 +00:00
Owner
Copy Link

Please resolve the comments and I'll figure out the rest

Please resolve the comments and I'll figure out the rest
akanyan requested changes 2024-07-21 23:59:31 +00:00
AttractVideoPlayer/AttractVideoPlayer.csproj Outdated
@ -0,0 +1,7 @@
<Project>
<PropertyGroup>
<AssemblyName>Assembly-CSharp.AttractVideoPlayer.mm</AssemblyName>
<Description>Forfeit (red menu) and restart (yellow menu)</Description>
akanyan commented 2024-07-21 19:32:51 +00:00
Owner
Copy Link

description unchanged

description unchanged
jujuforce marked this conversation as resolved
AttractVideoPlayer/MU3.Sequence/patch_Advertise.cs Outdated
@ -0,0 +10,4 @@
class patch_Advertise : Advertise
{
private bool checkButtonOrAime()
akanyan commented 2024-07-21 19:33:24 +00:00
Owner
Copy Link

doesn't this effectively disable guest login?

doesn't this effectively disable guest login?
jujuforce commented 2024-07-22 09:19:36 +00:00
Author
Contributor
Copy Link

oh crap you are right... I would be tempted to say we don't care about guest login but I don't like to remove a feature.
Let me cook something...

oh crap you are right... I would be tempted to say we don't care about guest login but I don't like to remove a feature. Let me cook something...
akanyan marked this conversation as resolved
jujuforce added 1 commit 2024-07-22 09:17:49 +00:00
jujuforce added 1 commit 2024-07-22 09:36:12 +00:00
akanyan force-pushed AttractVideoPlayer from 6afff88596 to 1023dee2b7 2024-07-22 13:00:56 +00:00 Compare
akanyan added 1 commit 2024-07-22 13:03:30 +00:00
akanyan added 1 commit 2024-07-22 14:51:47 +00:00
akanyan commented 2024-07-22 14:55:16 +00:00
Owner
Copy Link

I don't like how the state is stored in a file but I'll merge it as it is now.

I don't like how the state is stored in a file but I'll merge it as it is now.
akanyan merged commit 8cbc7e8b86 into main 2024-07-22 14:55:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
akanyan
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: akanyan/mu3-mods#2
No description provided.
Delete Branch "jujuforce/mu3-mods:AttractVideoPlayer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?