Little fix for the diva reader when trying to read a dificulty thats not a direct number #148

ThatzOkay · 2024-05-30T07:35:32Z

ThatzOkay commented

2024-05-30 07:35:32 +00:00

Instead of crashing and giving out a exception. Catch the exception give a friendly message and continue to the next song

ThatzOkay added 2 commits 2024-05-30 07:35:34 +00:00

Merge pull request 'develop' (#1 ) from Hay1tsme/artemis:develop into develop e15caeaa8f

Reviewed-on: ThatzOkay/artemis#1

Fix for diva reader when trying to read modded content. When it can't parse a number. So instead of crashing give a friendly error and continue d57aa93401

ThatzOkay commented

2024-05-30 11:09:27 +00:00

Can confrim score saving works with modded songs

Midorica commented

2024-06-08 15:29:42 +00:00

Seems good to me, ill approve the merge

Midorica merged commit 4b013d975b into develop

2024-06-08 15:29:50 +00:00

Midorica referenced this issue from a commit

2024-06-08 15:29:51 +00:00

Merge pull request 'Little fix for the diva reader when trying to read a dificulty thats not a direct number' (#148) from ThatzOkay/artemis:fix-diva-reader into develop

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#148