diva: added all previous commits, added username and password change #1

Dniel97 · 2023-02-18T20:17:00Z

Dniel97 commented

2023-02-18 20:17:00 +00:00

Changes

Changed update_profile() function to allow a single Dict instead of multiple values
Added passwd* Columns to profile table and added corresponding update/rollback sql scripts
Added handle_card_procedure_request(), handle_change_name_request () and handle_change_passwd_request() functions to DivaBase

Important

Not sure about the update to update_profile() because in order to change the values from the retuned LegacyRow it first needs to be converted to a Dict. I just was annoyed to pass 26 arguments to that function if I just needed to change one value lol. Let me know if I sould switch that back.

## Changes - Changed `update_profile()` function to allow a single Dict instead of multiple values - Added `passwd*` Columns to profile table and added corresponding update/rollback sql scripts - Added `handle_card_procedure_request()`, `handle_change_name_request ()` and `handle_change_passwd_request()` functions to DivaBase ## Important Not sure about the update to `update_profile()` because in order to change the values from the retuned `LegacyRow` it first needs to be converted to a Dict. I just was annoyed to pass 26 arguments to that function if I just needed to change one value lol. Let me know if I sould switch that back.

Dniel97 added 1 commit 2023-02-18 20:17:00 +00:00

c99bfda015

diva: added all previous commits, added username and password change

- Changed `update_profile()` function to allow a single Dict instead of multiple values
- Added `passwd*` Columns to profile table and added corresponding update/rollback sql scripts
- Added `handle_card_procedure_request()`, `handle_change_name_request ()` and `handle_change_passwd_request()` functions to DivaBase

Midorica commented

2023-02-19 05:36:07 +00:00

Hello Dniel

After doing quite a bit of troubleshooting with the new master branch, I was finally able to test out the PR request

So far everything looks good after doing a few sessions in the game and not even a single error was found.

Hay1tsme will be doing a review tomorrow for it

Thank you

Hello Dniel After doing quite a bit of troubleshooting with the new master branch, I was finally able to test out the PR request So far everything looks good after doing a few sessions in the game and not even a single error was found. Hay1tsme will be doing a review tomorrow for it Thank you

Midorica commented

2023-02-19 05:49:37 +00:00

Hello again,

I just finished the last tests i forgot about and you almost got it all good by the look of it

Only the handle_change_name_request did not apply the new username, the card_procedure_request and change_passwd_request appears to have both worked.

Edit: we found out it was caused by the limit of chars that didn't match with the game (10 instead of 8)

You might want to check for that last issue, maybe Hay have an idea for the update_profile

Thank you

Hello again, I just finished the last tests i forgot about and you almost got it all good by the look of it Only the handle_change_name_request did not apply the new username, the card_procedure_request and change_passwd_request appears to have both worked. Edit: we found out it was caused by the limit of chars that didn't match with the game (10 instead of 8) You might want to check for that last issue, maybe Hay have an idea for the update_profile Thank you

Dniel97 added 1 commit 2023-02-19 15:09:30 +00:00

8bdc2071da

diva: changed player_name length to 10

Hay1tsme commented

2023-02-19 19:02:53 +00:00

Why not just create a new function like update_name() that only updates the name. If the name change JUST changes the name field, there's no point in pulling down the entire profile just to write back 99% the same values.

Recommend you revert the changes to update_profile() and just create a seperate name change function.

Why not just create a new function like `update_name()` that only updates the name. If the name change JUST changes the name field, there's no point in pulling down the entire profile just to write back 99% the same values. Recommend you revert the changes to `update_profile()` and just create a seperate name change function.

Dniel97 commented

2023-02-19 19:26:25 +00:00

Why not just create a new function like update_name() that only updates the name. If the name change JUST changes the name field, there's no point in pulling down the entire profile just to write back 99% the same values.

Recommend you revert the changes to update_profile() and just create a seperate name change function.

This would not solve the problem, because that would require a function for the player_name, passwd, my_qst_id, my_qst_sts... if you dont want to write back 99% of the values as already done here df4efa1fda/titles/diva/base.py (L498).

So I cannot recommend reverting back to the old "25 arguments function". So either create a function for the every change (update_name(), update_passwd(), ...), maybe use sqlalchemy ORM model which might require "some" rewrites (profile.player_name = new_play_name) or rewrite the function to only update the profile columns/values which are not None (if this is even possible?).

> Why not just create a new function like `update_name()` that only updates the name. If the name change JUST changes the name field, there's no point in pulling down the entire profile just to write back 99% the same values. > > Recommend you revert the changes to `update_profile()` and just create a seperate name change function. This would not solve the problem, because that would require a function for the player_name, passwd, my_qst_id, my_qst_sts... if you dont want to write back 99% of the values as already done here https://gitea.tendokyu.moe/Hay1tsme/artemis/src/commit/df4efa1fda20f0c2a64dbbbf188f57cdb09153ac/titles/diva/base.py#L498. So I cannot recommend reverting back to the old "25 arguments function". So either create a function for the every change `(update_name(), update_passwd(), ...)`, maybe use sqlalchemy ORM model which might require "some" rewrites (`profile.player_name = new_play_name`) or rewrite the function to only update the profile columns/values which are not `None` (if this is even possible?).

Hay1tsme commented

2023-02-19 19:31:10 +00:00

Hm, you're right. We might be able to use **kwargs to our advantage here...

Hm, you're right. We might be able to use `**kwargs` to our advantage here...

Dniel97 added 1 commit 2023-02-19 21:57:03 +00:00

a7821fade8

diva: improved update_profile() function

Midorica commented

2023-02-22 23:26:48 +00:00

Hello Dniel,

Since the last issue has been fixed in your commit a7821fade8, the merge will now be done.

Thanks for your contribution!