Ongeki: Fix issue with technical award folder counts not being saved properly #128

Kumubou · 2024-04-17T01:49:58Z

Kumubou commented

2024-04-17 01:49:58 +00:00

This pull request is to fix an issue reported in #127 regarding technical award counts displayed in-game not being saved properly.

Be aware that this will only completely fix the issue on new accounts, existing accounts will only have the counts from their last session (and going forward) until manually fixed by the operator. There's more notes on how that may be fixed with an external script in the issue report.

This has only been tested on my personal instance with one actively used account and a couple of test accounts, so more testing may be needed.

This pull request is to fix an issue reported in https://gitea.tendokyu.moe/Hay1tsme/artemis/issues/127 regarding technical award counts displayed in-game not being saved properly. Be aware that this will only completely fix the issue on new accounts, existing accounts will only have the counts from their last session (and going forward) until manually fixed by the operator. There's more notes on how that may be fixed with an external script in the issue report. This has only been tested on my personal instance with one actively used account and a couple of test accounts, so more testing may be needed.

Kumubou added 3 commits 2024-04-17 01:49:59 +00:00

bd7e1cead0 Merge pull request 'develop' (#1 ) from Hay1tsme/artemis:develop into develop

Reviewed-on: Kumubou/artemis#1

39fc5772eb Fix handle_get_user_tech_count_api_request so that it'll properly return tech award counts

1346bab911 Implement get_tech_count (it was stubbed out)

Kumubou changed title from ~~Ongeki: Fix issue technical award folder counts not being saved properly~~ to Ongeki: Fix issue with technical award folder counts not being saved properly

2024-04-17 01:50:53 +00:00

Kumubou referenced this pull request

2024-04-17 01:51:40 +00:00

Ongeki: Certain game-wide stats don't save/display properly #127

Midorica commented

2024-04-17 13:18:58 +00:00

Hello Kumubou

May I know if this is ready for merging or did you need to add something else before i approve this?

Thank you!

Hello Kumubou May I know if this is ready for merging or did you need to add something else before i approve this? Thank you!

Kumubou commented

2024-04-18 01:47:41 +00:00

This should be good to go -- all that needed to be done is actually implement get_tech_count, and since the schema for that was already defined all that really needed to be done was have it run the SQL command and return the result (and then cast the result as a dict in handle_get_user_tech_count_api_request, or else the pops won't work and the returned result will end up crashing the game).

I don't know why it's trying to include the original rebasing as one of the commits, although I guess that won't matter once squashed (especially since the calculated file changes look correct).

This should be good to go -- all that needed to be done is actually implement `get_tech_count`, and since the schema for that was already defined all that really needed to be done was have it run the SQL command and return the result (and then cast the result as a dict in `handle_get_user_tech_count_api_request`, or else the pops won't work and the returned result will end up crashing the game). I don't know why it's trying to include the original rebasing as one of the commits, although I guess that won't matter once squashed (especially since the calculated file changes look correct).

Midorica merged commit 36ab38b1ee into develop

2024-04-18 21:45:59 +00:00

Midorica referenced this issue from a commit

2024-04-18 21:46:00 +00:00

Merge pull request 'Ongeki: Fix issue with technical award folder counts not being saved properly' (#128) from Kumubou/artemis:develop into develop

Hay1tsme referenced this pull request

2024-04-24 16:54:43 +00:00

Ongeki: Certain game-wide stats don't save/display properly #127

Sign in to join this conversation.

No reviewers