Hay1tsme/artemis
24
41
Fork 34
Code Issues 11 Pull Requests 4 Packages Projects Releases Wiki Activity

Chunithm New!! (Plus) #7

Merged
Midorica merged 9 commits from Dniel97/artemis:chuni_importer_fix into develop 2023-03-01 20:19:41 +00:00
Conversation 1 Commits 9 Files Changed 6 +12 -10
Dniel97 commented 2023-03-01 20:13:18 +00:00
Collaborator
Copy Link
  • Changed worldsEndTag to size 7 because the largest value is "Invalid"
  • Changed hostname to listen_address
  • Fixed "NoneType" error in if fumen_path.text is not None:
- Changed `worldsEndTag` to size 7 because the largest value is "Invalid" - Changed `hostname` to `listen_address` - Fixed "NoneType" error in `if fumen_path.text is not None:`
Dniel97 added 8 commits 2023-03-01 20:13:18 +00:00
Dniel97 added 1 commit 2023-03-01 20:18:33 +00:00
Midorica commented 2023-03-01 20:19:29 +00:00
Collaborator
Copy Link

Hello Dniel,

As we discussed, this merge request will be approved as we were able to reproduce the issue on both instances we tested.

With the changes you did, I was indeed able to confirm everything was fixed regarding the Invalid value with the worldEnd charts in the reader and the listen hostname in the chunithm new settings request.

Thank you!

Hello Dniel, As we discussed, this merge request will be approved as we were able to reproduce the issue on both instances we tested. With the changes you did, I was indeed able to confirm everything was fixed regarding the Invalid value with the worldEnd charts in the reader and the listen hostname in the chunithm new settings request. Thank you!
Midorica merged commit e98a7c8ae0 into develop 2023-03-01 20:19:41 +00:00
Dniel97 deleted branch chuni_importer_fix 2023-04-10 16:59:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
aimedb

Issue relating to AimeDB

  
bug

Something is not working

  
chuni

Relates to Pre-new Chunithm

  
chusan

Relates to post-New Chunithm

  
cxb

Relates to Crossbeats

  
database

Relates to the database in general

  
diva

Relates to Project Diva

  
doc

Relates to documentation of Artemis

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Relates to the webui

  
help wanted

Need some help

  
idac

Relates to InitialD The Arcade

  
idz

Relates to InitialD Arcade Stage Zero

  
invalid

Something is wrong

  
maidx

Relates to Maimai DX

  
ongeki

Relates to Ongeki

  
pokken

Relates to Pokken

  
question

More information is needed

  
seen

This issue or PR has been seen

  
system

This issue or PR pertains to the overall system

  
testing

This issue or PR is ready for testing

  
wacca

Relates to Wacca

  
waiting

Waiting for issue reporter/PR author feedback

  
wip

This issue or PR is being worked on

  
wontfix

This won't be fixed

No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#7
No description provided.
Delete Branch "Dniel97/artemis:chuni_importer_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?