Hay1tsme/artemis
30
52
Fork 48
Code Issues 5 Pull Requests 2 Packages Projects Releases Wiki Activity

fix: dockerfile fixes #60

Merged
Midorica merged 2 commits from Rylie/artemis:fix/docker into develop 2023-11-08 20:53:01 +00:00
Conversation 2 Commits 2 Files Changed 1 +2 -2
Rylie commented 2023-11-05 04:13:00 +00:00
Contributor
Copy Link
  • add pkg-config to dockerfile initialization, since the dockerfile build process breaks without it
  • renamed log to logs for consistency with the documentation
- add `pkg-config` to dockerfile initialization, since the dockerfile build process breaks without it - renamed `log` to `logs` for consistency with the documentation
Rylie added 2 commits 2023-11-05 04:13:01 +00:00
fix(docker): add pkg-config for docker build process b4a0736f7b
fix(docker): rename log to logs for consistency 040742a9a4
phantomlan commented 2023-11-05 17:03:59 +00:00
Contributor
Copy Link

Tested and yeah, missed those small points in my last docker update, looks good

Tested and yeah, missed those small points in my last docker update, looks good
Midorica commented 2023-11-08 20:52:51 +00:00
Collaborator
Copy Link

Hello,

Since this is confirmed to be working and tested, I will approve the merge

Thank you for the fix!

Hello, Since this is confirmed to be working and tested, I will approve the merge Thank you for the fix!
Midorica merged commit c2a330f42c into develop 2023-11-08 20:53:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aimedb
Issue relating to AimeDB
bug
Something is not working
chuni
Relates to Pre-new Chunithm
chusan
Relates to post-New Chunithm
cxb
Relates to Crossbeats
database
Relates to the database in general
diva
Relates to Project Diva
doc
Relates to documentation of Artemis
duplicate
This issue or pull request already exists
enhancement
New feature
frontend
Relates to the webui
help wanted
Need some help
idac
Relates to InitialD The Arcade
idz
Relates to InitialD Arcade Stage Zero
invalid
Something is wrong
maidx
Relates to Maimai DX
ongeki
Relates to Ongeki
pokken
Relates to Pokken
question
More information is needed
seen
This issue or PR has been seen
system
This issue or PR pertains to the overall system
testing
This issue or PR is ready for testing
wacca
Relates to Wacca
waiting
Waiting for issue reporter/PR author feedback
wip
This issue or PR is being worked on
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dniel97 Midorica Hay1tsme
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#60
No description provided.
Delete Branch "Rylie/artemis:fix/docker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?