Chunithm: Fix getUserMusic duplicate songs and fix missing song diffs #54

DSRLIN · 2023-10-26T05:45:01Z

DSRLIN commented

2023-10-26 05:45:01 +00:00

The missing song diffs bugfix is the code between line 603 to line 615.

The original code will cause each page's last song only insert once.

e.g. if you played songId 2023's diff 0, diff 1, diff 2, diff 3, then after insert diff 0 to the song list, the code will go to if len(song_list) >= max_ct: next_idx += len(song_list) part, ignoring diff 1 to 3. the modified code will add all diffs for the last element for the list.

I've tested this on my server with 4 accounts, each with 1000+ play bests. And the code seems works fine.

Also contains #45.

The missing song diffs bugfix is the code between line 603 to line 615. <br> The original code will cause each page's last song only insert once. <br> e.g. if you played songId 2023's diff 0, diff 1, diff 2, diff 3, then after insert diff 0 to the song list, the code will go to if len(song_list) >= max_ct: next_idx += len(song_list) part, ignoring diff 1 to 3. the modified code will add all diffs for the last element for the list. <br> I've tested this on my server with 4 accounts, each with 1000+ play bests. And the code seems works fine. <br> Also contains https://gitea.tendokyu.moe/Hay1tsme/artemis/issues/45.

DSRLIN added 2 commits 2023-10-26 05:45:02 +00:00

fix chuni songlist duplicate songs and missing diff b5ce13d1f1

update bug 3259552c29

Midorica commented

2023-10-27 01:51:30 +00:00

Hello,

As discussed in the issue reported, this PR has been tested and works quite nicely and fixed the bug I've seen with duplicated loaded IDs on my own server.

Thank you!

Hello, As discussed in the issue reported, this PR has been tested and works quite nicely and fixed the bug I've seen with duplicated loaded IDs on my own server. Thank you!

Midorica merged commit 1b5c335f4e into develop

2023-10-27 01:51:45 +00:00

Midorica referenced this issue from a commit

2023-10-27 01:51:46 +00:00

Merge pull request 'Chunithm: Fix getUserMusic duplicate songs and fix missing song diffs' (#54) from DSRLIN/artemis-bugfix:develop into develop

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#54

Allow edits from maintainers