Chunithm: Fix getUserMusic duplicate songs and fix missing song diffs #54
No reviewers
Labels
No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Hay1tsme/artemis#54
Loading…
Reference in New Issue
No description provided.
Delete Branch "DSRLIN/artemis-bugfix:develop"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The missing song diffs bugfix is the code between line 603 to line 615.
The original code will cause each page's last song only insert once.
e.g. if you played songId 2023's diff 0, diff 1, diff 2, diff 3, then after insert diff 0 to the song list, the code will go to if len(song_list) >= max_ct: next_idx += len(song_list) part, ignoring diff 1 to 3. the modified code will add all diffs for the last element for the list.
I've tested this on my server with 4 accounts, each with 1000+ play bests. And the code seems works fine.
Also contains #45.
Hello,
As discussed in the issue reported, this PR has been tested and works quite nicely and fixed the bug I've seen with duplicated loaded IDs on my own server.
Thank you!