Updates and Fixes for Dockerfile and docker-compose, and docker installation guide #50

phantomlan · 2023-10-21T16:02:32Z

phantomlan commented

2023-10-21 16:02:32 +00:00

This pull requests fixes small issues residing withing Dockerfile and docker-compose.yml files

Fixes missing read.py causing issues starting up Artemis inside container
Trims image size for DB and Memcached by using alpinelinux docker counterparts
Changes default mysqldb to mariadb
Adds documentation guide for running inside docker

Tested with wsl2-debian, debian 12 baremetal machine, and ubuntu virtual machine

This pull requests fixes small issues residing withing Dockerfile and docker-compose.yml files - Fixes missing read.py causing issues starting up Artemis inside container - Trims image size for DB and Memcached by using alpinelinux docker counterparts - Changes default mysqldb to mariadb - Adds documentation guide for running inside docker Tested with wsl2-debian, debian 12 baremetal machine, and ubuntu virtual machine

phantomlan added 4 commits 2023-10-21 16:02:33 +00:00

- update docker-compose.yml a3d2955fce

- update mysqldb to mariadb-alpine
- update mysql healthcheck to also include Password
- update memcached to alpine counterpart
- update phpmyadmin port to not collide with ARTEMiS main app
- add commented out options for DB Persistency

- update Dockerfile
- add read.py to Dockerfile

- add docs/INSTALL_DOCKER.md guide

- update docker-compose database charset and collation to utf8mb4 5420076c8e

- update TODO list in docker guide
- update readme.md

- prettier docker guide 12d0a3f927

- update docker-compose to reflect 1 level higher config folder

Update docs/INSTALL_DOCKER.md 7f1ff60b9d

Midorica commented

2023-10-21 16:10:32 +00:00

Hello phantomlan,

I'm really glad to see the fixes for the docker install as well as the documentation you have added for it

Since everything is looking good, i will be approving this PR but since it tries to merge into the master branch, i will check what is possible as we never merge into master directly

Hello phantomlan, I'm really glad to see the fixes for the docker install as well as the documentation you have added for it Since everything is looking good, i will be approving this PR but since it tries to merge into the master branch, i will check what is possible as we never merge into master directly

phantomlan commented

2023-10-21 16:14:05 +00:00

I can close this pull request and change to merge with develop branch if this will be better

Midorica changed title from ~~Updates and Fixes for Dockerfile and docker-compose, and docker installation guide~~ to Updates and Fixes for Dockerfile and docker-compose, and docker installation guide

2023-10-21 16:27:47 +00:00

Midorica changed target branch from master to develop

2023-10-21 16:27:49 +00:00

Midorica commented

2023-10-21 16:28:47 +00:00

You might have to indeed since switching it to develop reports a conflict with one of the file titles/mai2/dx.py

Thank you

You might have to indeed since switching it to develop reports a conflict with one of the file titles/mai2/dx.py Thank you

phantomlan commented

2023-10-21 18:17:59 +00:00

fixed dx.py

phantomlan added 1 commit 2023-10-21 18:36:08 +00:00

update dx.py e9637c94de

phantomlan commented

2023-10-21 18:47:56 +00:00

I'm not too sure if thats how it's supposed to work, since i didn't edit dx.py at all, if something is wrong please cancel the pull and i'll adjust everything to pull into develop branch properly