Aime Locks/Bans and Chunithm Improvements #47

EmmyHeart · 2023-10-20T04:59:27Z

EmmyHeart commented

2023-10-20 04:59:27 +00:00

~~can you tell what my favorite allnet game is?~~
Changes in this PR:

Aime card locks/bans in the DB are now reflected to the cabinets
Added code for the song rankings, so in Plost and under(?), you can now see the popular songs based on playlogs for your version
Added some code for ensuring playlogs always have a romVersion attached, even if the game doesn't provide it
Optimized the rival music list (was unnecessarily retrieving all playlogs and sorting, when there is a table for this specific purpose)
Started work on Team Courses, but I need some help with the format. Still stubbed, but my basic structure is there
Removed rank scale option from the example config, as it does nothing

I think it's important that we start versioning Chunithm tables, so that loading an older version with the same Aime doesn't cause corruption as it does currently. The romVersion change in playlogs is an important step in the right direction, but actual DB mods need to be done. I'll do some more research and get this going asap.

~~can you tell what my favorite allnet game is?~~ Changes in this PR: - Aime card locks/bans in the DB are now reflected to the cabinets - Added code for the song rankings, so in Plost and under(?), you can now see the popular songs based on playlogs for your version - Added some code for ensuring playlogs always have a romVersion attached, even if the game doesn't provide it - Optimized the rival music list (was unnecessarily retrieving all playlogs and sorting, when there is a table for this specific purpose) - Started work on Team Courses, but I need some help with the format. Still stubbed, but my basic structure is there - Removed rank scale option from the example config, as it does nothing I think it's important that we start versioning Chunithm tables, so that loading an older version with the same Aime doesn't cause corruption as it does currently. The romVersion change in playlogs is an important step in the right direction, but actual DB mods need to be done. I'll do some more research and get this going asap.

EmmyHeart added 6 commits 2023-10-20 04:59:28 +00:00

8fcd227b33 Added functions for checking if Aime card is locked or banned

719ae9cfb1 Added checks for if Aime card is locked or banned, and pass that status to the game

3f8c62044c Optimized rival music list, added ranking API, and began work on Team Courses (need help)

32903d979e Added code for song rankings using romVersion, and ensuring romVersion is set on playlog upsert

21cb37001b Stubbed Team Course functions as they do not currently do anything

990d60cf27 Forgot to remove rank scale option from the example config, as it does literally nothing now lol

Midorica commented

2023-10-27 17:25:30 +00:00

Hello EmmyHeart,

As discussed, since this was properly tested, I will now be approving this merge request

Thank you!