ONGEKI Rival Functionality #36
Reference in New Issue
Block a user
No description provided.
Delete Branch "2TT/artemis:develop"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changes
put_rival
anddelete_rival
handle_get_user_rival_api_request
andhandle_get_user_rival_data_api_request
developto ONGEKI Rival FunctionalityThanks for the PR!
I just checked the code and I see some problems with it.
The first issue I noticed is in the file frontend.py L46, if you have an empty
rival_list
thenrival_info
is never set and lead to a crash because the variable is unset.The second question I have is the addition of a new function
get_profile_data_ignore_version()
frontend.py L38. You added the function but only check for the profile with the version number 7 (bright MEMORY) later, you could either directly use theget_profile(aime_id, version=7)
function or even better get the latest profile version or give the choice which profile version should be loaded,bright (6)
orbright MEMORY (7)
. Also the functionget_profile_data_ignore_version()
just gets a single profile and that one could even be older than version 7.I hope I explained the issues I have with the submitted code properly and I hope you can fix them so they can be merged :)
rival_info
is now defined even with an empty rival listget_profile_data_ignore_version()
Hello 2TT,
I might give it a try this weekend just to be sure everything works properly before approving the merge.
At a first glance, everything appears to be good and I also see the small fix you did regarding the typo for one of the request which I totally missed
Thank you
Hello 2TT,
I just found some time to test the code and everything is working
The PR will now be approved
Thank you!