Hay1tsme
/
artemis
20
38
Fork 28
Code Issues 13 Pull Requests 3 Packages Projects Releases Wiki Activity

Fix wrong id being used to check for Chunithm WORLD'S END charts #33

Merged
Midorica merged 2 commits from ASleepyCat/artemis:fix-worlds-end-id into develop 2023-09-12 04:37:01 +00:00
Conversation 3 Commits 2 Files Changed 1 +4 -2
ASleepyCat commented 2023-08-15 09:01:22 +00:00
Contributor
Copy Link

Not sure if using the id of 4 was intentional, but it looks like WORLD'S END corresponds to id 5.

Not sure if using the id of 4 was intentional, but it looks like WORLD'S END corresponds to id 5.
ASleepyCat added 1 commit 2023-08-15 09:01:24 +00:00
ASleepyCat changed title from Fix wrong id being used to check for WORLD'S END charts to Fix wrong id being used to check for WORLD'S END Chunithm charts 2023-08-15 09:03:46 +00:00
ASleepyCat changed title from Fix wrong id being used to check for WORLD'S END Chunithm charts to Fix wrong id being used to check for Chunithm WORLD'S END charts 2023-08-15 09:09:57 +00:00
ASleepyCat force-pushed fix-worlds-end-id from 098dbe4517 to b1074a6e0d 2023-08-16 00:07:42 +00:00 Compare
ASleepyCat force-pushed fix-worlds-end-id from b1074a6e0d to 4c728a828a 2023-08-16 12:33:41 +00:00 Compare
ASleepyCat force-pushed fix-worlds-end-id from 4c728a828a to 72c48ba055 2023-08-20 02:23:33 +00:00 Compare
ASleepyCat force-pushed fix-worlds-end-id from 72c48ba055 to 27ac224b9f 2023-08-21 08:42:05 +00:00 Compare
ASleepyCat force-pushed fix-worlds-end-id from 27ac224b9f to 0a0fdb6931 2023-08-30 11:48:25 +00:00 Compare
ASleepyCat force-pushed fix-worlds-end-id from 0a0fdb6931 to 32d14777e3 2023-09-01 09:22:08 +00:00 Compare
Midorica commented 2023-09-05 21:56:36 +00:00
Collaborator
Copy Link

Hello,

This cannot be approved as it is right now since Chunithm Paradise and older uses ID 4 for WORLD'S END.

You would need to tweak the code to do something like check if it says "WORLD'S END" in the data field and ID equals 5 or 4 to determine if the imported data is from New+ or Paradise or older.

Hello, This cannot be approved as it is right now since Chunithm Paradise and older uses ID 4 for WORLD'S END. You would need to tweak the code to do something like check if it says "WORLD'S END" in the data field and ID equals 5 or 4 to determine if the imported data is from New+ or Paradise or older.
ASleepyCat force-pushed fix-worlds-end-id from 32d14777e3 to 438686fdeb 2023-09-09 14:03:15 +00:00 Compare
ASleepyCat added 1 commit 2023-09-09 14:04:24 +00:00
ASleepyCat force-pushed fix-worlds-end-id from 142cc21653 to 438686fdeb 2023-09-09 14:05:37 +00:00 Compare
ASleepyCat commented 2023-09-09 14:08:09 +00:00
Author
Contributor
Copy Link

I didn't know that was the case, I've updated it so it should be correct now.

I didn't know that was the case, I've updated it so it should be correct now.
ASleepyCat force-pushed fix-worlds-end-id from 438686fdeb to 4a916cb4d1 2023-09-10 02:30:22 +00:00 Compare
Midorica commented 2023-09-12 04:36:47 +00:00
Collaborator
Copy Link

That appears to now be good, i'll approve the merge

Thank you!

That appears to now be good, i'll approve the merge Thank you!
Midorica merged commit 2affd0aae9 into develop 2023-09-12 04:37:01 +00:00
ASleepyCat deleted branch fix-worlds-end-id 2023-09-13 11:20:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
aimedb

Issue relating to AimeDB

  
bug

Something is not working

  
chuni

Relates to Pre-new Chunithm

  
chusan

Relates to post-New Chunithm

  
cxb

Relates to Crossbeats

  
database

Relates to the database in general

  
diva

Relates to Project Diva

  
doc

Relates to documentation of Artemis

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Relates to the webui

  
help wanted

Need some help

  
idac

Relates to InitialD The Arcade

  
idz

Relates to InitialD Arcade Stage Zero

  
invalid

Something is wrong

  
maidx

Relates to Maimai DX

  
ongeki

Relates to Ongeki

  
pokken

Relates to Pokken

  
question

More information is needed

  
seen

This issue or PR has been seen

  
system

This issue or PR pertains to the overall system

  
testing

This issue or PR is ready for testing

  
wacca

Relates to Wacca

  
waiting

Waiting for issue reporter/PR author feedback

  
wip

This issue or PR is being worked on

  
wontfix

This won't be fixed

No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#33
No description provided.
Delete Branch "ASleepyCat/artemis:fix-worlds-end-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?