Hay1tsme/artemis
30
52
Fork 48
Code Issues 5 Pull Requests 2 Packages Projects Releases Wiki Activity

O.N.G.E.K.I.: Card Maker fixes, improvements and bug fixes #25

Merged
Midorica merged 1 commits from Dniel97/artemis:cardmaker_ongeki_fix into develop 2023-07-16 17:06:45 +00:00
Conversation 1 Commits 1 Files Changed 14 +87 -44
Dniel97 commented 2023-07-12 09:31:40 +00:00
Collaborator
Copy Link

Changes:

  • Added the possibility to change compatibleCardMakerVersion per O.N.G.E.K.I. game version in config/ongeki.yaml:
versions:
  6: # O.N.G.E.K.I. bright
    card_maker: 1.30.01
  • Changed the credits config to the default 370 instead of 360
  • Added start_date to the events to show new events
  • Fixed Card Maker Gachas to only allow "Select Gacha" once
  • Fixed the get_profile_rating_log database query

Important

Make sure to update the database for SDDT to version 5:

python dbutils.py --game SDDT  upgrade
## Changes: - Added the possibility to change `compatibleCardMakerVersion` per O.N.G.E.K.I. game version in `config/ongeki.yaml`: ```yaml versions: 6: # O.N.G.E.K.I. bright card_maker: 1.30.01 ``` - Changed the credits config to the default 370 instead of 360 - Added `start_date` to the events to show new events - Fixed Card Maker Gachas to only allow "Select Gacha" once - Fixed the `get_profile_rating_log` database query ## Important Make sure to update the database for SDDT to version 5: ``` python dbutils.py --game SDDT upgrade ```
Dniel97 added 2 commits 2023-07-12 09:31:41 +00:00
Merge remote-tracking branch 'origin/develop' into fork_develop 36d338e618
ongeki: card maker config added, small fixes, improved credits 6a41dac46c 
- Changed the credits config to the default 370 instead of 360
- Added `start_date` to the events to show new events
- Fixed Card Maker Gachas to only allow "Select Gacha" once
- Fixed the `get_profile_rating_log` database query
Midorica commented 2023-07-16 17:06:37 +00:00
Collaborator
Copy Link

Hello Dniel,

From the look of it, this seems to fix a few things that we did typo and forgot entirely.

I'll approve the merge now

Hello Dniel, From the look of it, this seems to fix a few things that we did typo and forgot entirely. I'll approve the merge now
Midorica merged commit c6e7100f51 into develop 2023-07-16 17:06:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
aimedb
Issue relating to AimeDB
bug
Something is not working
chuni
Relates to Pre-new Chunithm
chusan
Relates to post-New Chunithm
cxb
Relates to Crossbeats
database
Relates to the database in general
diva
Relates to Project Diva
doc
Relates to documentation of Artemis
duplicate
This issue or pull request already exists
enhancement
New feature
frontend
Relates to the webui
help wanted
Need some help
idac
Relates to InitialD The Arcade
idz
Relates to InitialD Arcade Stage Zero
invalid
Something is wrong
maidx
Relates to Maimai DX
ongeki
Relates to Ongeki
pokken
Relates to Pokken
question
More information is needed
seen
This issue or PR has been seen
system
This issue or PR pertains to the overall system
testing
This issue or PR is ready for testing
wacca
Relates to Wacca
waiting
Waiting for issue reporter/PR author feedback
wip
This issue or PR is being worked on
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dniel97 Midorica Hay1tsme
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#25
No description provided.
Delete Branch "Dniel97/artemis:cardmaker_ongeki_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?