[BUGFIX] Fixed Chusan Map Overload #175

EmmyHeart · 2024-09-14T01:34:08Z

EmmyHeart commented

2024-09-14 01:34:08 +00:00

As part of the game's requests to the title server, it specifies a list of map areas that it wants progress for. With the previous code, we sent back all of the maps, which the game seemed to not care about, but if the map progress table is large (e.g. with certain map omnimixes), the size of the output can go far beyond what the response parser can take, leading to no map progress loading at all.

This commit modifies how get_map_areas works to only return the maps that the game requested, saving network bandwith for unavailable maps and ensuring that the parser limit should never be reached.

This bug may also be present in Paradise Lost and older, but I have not been able to test.

As part of the game's requests to the title server, it specifies a list of map areas that it wants progress for. With the previous code, we sent back all of the maps, which the game seemed to not care about, but if the map progress table is large (e.g. with certain map omnimixes), the size of the output can go far beyond what the response parser can take, leading to no map progress loading at all. This commit modifies how get_map_areas works to **only** return the maps that the game requested, saving network bandwith for unavailable maps and ensuring that the parser limit _should_ never be reached. This bug may also be present in Paradise Lost and older, but I have not been able to test.

EmmyHeart added 2 commits 2024-09-14 01:34:09 +00:00

Fix map overload in Chusan 8f4c08f825

Fix map overload in Chusan 82004cb743

Hay1tsme commented

2024-09-14 04:34:38 +00:00

Confirmed over discord, merging

Hay1tsme merged commit 6f6a300879 into develop

2024-09-14 04:34:45 +00:00

Hay1tsme referenced this issue from a commit

2024-09-14 04:34:45 +00:00

Merge pull request '[BUGFIX] Fixed Chusan Map Overload' (#175) from EmmyHeart/artemis:develop into develop

Sign in to join this conversation.