DIVA made some festa stuff configurable in config #161

Kayori · 2024-06-29T22:25:45Z

Kayori commented

2024-06-29 22:25:45 +00:00

No description provided.

Kayori added 14 commits 2024-06-29 22:25:46 +00:00

Merge pull request 'develop' (#2 ) from Hay1tsme/artemis:develop into develop 5ba041b32b

Reviewed-on: ThatzOkay/artemis#2

very basic diva frontend 1b5b9d7f9a

Basic working diva frontend with name editing and lv string editing. Working on playlog page 1f9c1798c4

accidentally changed example config 7d8093bb54

develop branch config da55e3e877

Working diva frontend d456ed365c

Merge pull request 'develop' (#3 ) from Hay1tsme/artemis:develop into develop 21a09f2de9

Reviewed-on: ThatzOkay/artemis#3

Changed return from full result to just True or False a6ca1b3392

Merge branch 'ThatzOkay-feature/diva-frontend' into develop 74e2130747

Merge pull request 'develop' (#4 ) from Hay1tsme/artemis:develop into develop 8947179127

Reviewed-on: ThatzOkay/artemis#4

Merge branch 'develop' of https://gitea.tendokyu.moe/ThatzOkay/artemis into develop f999269e41

Merge pull request 'develop' (#6 ) from Hay1tsme/artemis:develop into develop 07ec4e5263

Reviewed-on: ThatzOkay/artemis#6

Merge pull request 'develop' (#7 ) from Hay1tsme/artemis:develop into develop 4a18f6b3bc

Reviewed-on: ThatzOkay/artemis#7

configurable festa options e0e63a9a13

Hay1tsme reviewed 2024-06-29 23:04:28 +00:00

example_config/diva.yaml Outdated

						
				@ -1,6 +1,10 @@

				server:

				  enable: True

				  loglevel: "info"

				  festaEnable: True

Hay1tsme commented

2024-06-29 23:04:28 +00:00

These should use underscore_case like the rest of the options

Hay1tsme commented

2024-06-29 23:05:06 +00:00

Please also fix the conflict with the changelog. Other then that and the underscore thing, looks fine to me

Kayori added 2 commits 2024-06-30 10:27:07 +00:00

Merge pull request 'develop' (#8 ) from Hay1tsme/artemis:develop into develop d439483aec

Reviewed-on: ThatzOkay/artemis#8

Merge branch 'develop' into diva_configire_festa eb275062a1

Kayori added 1 commit 2024-06-30 10:54:48 +00:00

fix disable. Fix casing in options 97e1d5da05

Kayori commented

2024-06-30 10:56:19 +00:00

Fixed it

Kayori commented

2024-06-30 10:57:59 +00:00

For later i was thinking about moving festa to a per arcade basis but i dont think that is used much for artemis. But that is probably how it would actually work

Kayori added 1 commit 2024-07-05 08:07:14 +00:00

Merge branch 'develop' into diva_configire_festa 58bdeb9290

Hay1tsme commented

2024-07-06 00:47:34 +00:00

Per-arcade could be a cool feature, but this is fine for now. Thanks for contributing!

Hay1tsme merged commit 51a47e51d9 into develop

2024-07-06 00:47:44 +00:00

Hay1tsme referenced this issue from a commit

2024-07-06 00:47:47 +00:00

Merge pull request 'DIVA made some festa stuff configurable in config' (#161) from ThatzOkay/artemis:diva_configire_festa into develop

Kayori deleted branch diva_configire_festa

2024-07-08 20:52:50 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#161