Hay1tsme/artemis
24
41
Fork 34
Code Issues 11 Pull Requests 4 Packages Projects Releases Wiki Activity

[chuni] Add correct endpoint iter_counts for all versions with encryption #151

Open
beerpsi wants to merge 3 commits from beerpsi/artemis:fix/chuni/correct-iter-counts into develop
pull from: beerpsi/artemis:fix/chuni/correct-iter-counts
merge into: Hay1tsme:develop
Conversation 3 Commits 3 Files Changed 3 +67 -20
beerpsi commented 2024-06-12 09:11:14 +00:00
Contributor
Copy Link

Also add support for international encryption keys, closing #129

Also add support for international encryption keys, closing #129
beerpsi added 1 commit 2024-06-12 09:11:14 +00:00
beerpsi added 1 commit 2024-06-15 15:22:48 +00:00
Midorica commented 2024-06-16 16:32:07 +00:00
Collaborator
Copy Link

Regarding this pull request, could you modify the docs/game_specific_info.md to reflect the changes you just did so people knows how to assign the key, iv and hash for intl?

Also please add the change to the changelog

Thanks!

Regarding this pull request, could you modify the docs/game_specific_info.md to reflect the changes you just did so people knows how to assign the key, iv and hash for intl? Also please add the change to the changelog Thanks!
Hay1tsme added the
enhancement
chuni
waiting
 labels 2024-06-17 15:24:52 +00:00
beerpsi added 1 commit 2024-06-18 02:39:28 +00:00
beerpsi commented 2024-06-18 02:42:28 +00:00
Author
Contributor
Copy Link

Should be done. However, as discussed in Discord, there's still the problem of SUPER STAR (SDGS 1.00) and SUPER STAR+ (SDGS 1.05) being treated as the same internal version (VER_CHUNITHM_PARADISE), which makes assigning encryption keys difficult since they have different keys and salts. I'm open to suggestions on how to solve this. 9_int could be assigned to SUPER STAR and 10_int to SUPER STAR+, but that will add a bunch of checks and look fairly ugly.

Should be done. However, as discussed in Discord, there's still the problem of SUPER STAR (SDGS 1.00) and SUPER STAR+ (SDGS 1.05) being treated as the same internal version (`VER_CHUNITHM_PARADISE`), which makes assigning encryption keys difficult since they have different keys and salts. I'm open to suggestions on how to solve this. `9_int` could be assigned to SUPER STAR and `10_int` to SUPER STAR+, but that will add a bunch of checks and look fairly ugly.
Hay1tsme commented 2024-06-20 18:39:48 +00:00
Owner
Copy Link

This PR fell out of date with the lumi update, oops

This PR fell out of date with the lumi update, oops
This pull request has changes conflicting with the target branch.
  • changelog.md
  • titles/chuni/index.py
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/chuni/correct-iter-counts:beerpsi-fix/chuni/correct-iter-counts
git checkout beerpsi-fix/chuni/correct-iter-counts

Merge

Merge the changes and update on Gitea.
git checkout develop
git merge --no-ff beerpsi-fix/chuni/correct-iter-counts
git checkout develop
git merge --ff-only beerpsi-fix/chuni/correct-iter-counts
git checkout beerpsi-fix/chuni/correct-iter-counts
git rebase develop
git checkout develop
git merge --no-ff beerpsi-fix/chuni/correct-iter-counts
git checkout develop
git merge --squash beerpsi-fix/chuni/correct-iter-counts
git checkout develop
git merge --ff-only beerpsi-fix/chuni/correct-iter-counts
git checkout develop
git merge beerpsi-fix/chuni/correct-iter-counts
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
aimedb

Issue relating to AimeDB

  
bug

Something is not working

  
chuni

Relates to Pre-new Chunithm

  
chusan

Relates to post-New Chunithm

  
cxb

Relates to Crossbeats

  
database

Relates to the database in general

  
diva

Relates to Project Diva

  
doc

Relates to documentation of Artemis

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Relates to the webui

  
help wanted

Need some help

  
idac

Relates to InitialD The Arcade

  
idz

Relates to InitialD Arcade Stage Zero

  
invalid

Something is wrong

  
maidx

Relates to Maimai DX

  
ongeki

Relates to Ongeki

  
pokken

Relates to Pokken

  
question

More information is needed

  
seen

This issue or PR has been seen

  
system

This issue or PR pertains to the overall system

  
testing

This issue or PR is ready for testing

  
wacca

Relates to Wacca

  
waiting

Waiting for issue reporter/PR author feedback

  
wip

This issue or PR is being worked on

  
wontfix

This won't be fixed

No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#151
No description provided.
Delete Branch "beerpsi/artemis:fix/chuni/correct-iter-counts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?