Hay1tsme/artemis
24
41
Fork 34
Code Issues 11 Pull Requests 4 Packages Projects Releases Wiki Activity

Diva front end #150

Merged
Hay1tsme merged 12 commits from ThatzOkay/artemis:feature/diva-frontend into develop 2024-06-22 02:03:03 +00:00
Conversation 6 Commits 12 Files Changed 9 +704 -2
ThatzOkay commented 2024-06-11 20:00:39 +00:00
Contributor
Copy Link

Basic diva frontend implemented. Changing name and level string working. And some basic playlog page which needs more data

Basic diva frontend implemented. Changing name and level string working. And some basic playlog page which needs more data
ThatzOkay added 5 commits 2024-06-11 20:00:40 +00:00 
Reviewed-on: ThatzOkay/artemis#2
ThatzOkay added 1 commit 2024-06-16 12:09:13 +00:00
ThatzOkay changed title from WIP: Diva front end to Diva front end 2024-06-16 12:09:55 +00:00
ThatzOkay commented 2024-06-16 12:10:41 +00:00
Author
Contributor
Copy Link

FrontEnd working great. Just not sure about clr status. In which one corrosponds to what. Kinda weird that it is skipping 0 and 1 but if that is how it works. Sure..

FrontEnd working great. Just not sure about clr status. In which one corrosponds to what. Kinda weird that it is skipping 0 and 1 but if that is how it works. Sure..
Hay1tsme added the
enhancement
diva
testing
frontend
 labels 2024-06-17 15:28:27 +00:00
Hay1tsme reviewed 2024-06-17 15:37:57 +00:00
titles/diva/schema/profile.py Outdated
@ -103,3 +103,3 @@
f"update_profile: failed to update profile! profile: {aime_id}"
)
return None
return result
Hay1tsme commented 2024-06-17 15:37:57 +00:00
Owner
Copy Link

Any reason you're returning the entire result object instead of just true or false?

Any reason you're returning the entire result object instead of just true or false?
ThatzOkay commented 2024-06-17 20:24:15 +00:00
Author
Contributor
Copy Link

Yeah returning true or false would be better. I have now changed it

Yeah returning true or false would be better. I have now changed it
ThatzOkay added 1 commit 2024-06-17 20:24:06 +00:00
Midorica commented 2024-06-20 12:20:50 +00:00
Collaborator
Copy Link

Just to be sure, everything was tested even when pulling the branch like a new instance?

I can't test myself so i just want to be 100% sure before we merge

Thanks!

Just to be sure, everything was tested even when pulling the branch like a new instance? I can't test myself so i just want to be 100% sure before we merge Thanks!
Hay1tsme commented 2024-06-20 18:39:58 +00:00
Owner
Copy Link

This PR fell out of date with the lumi update, oops

This PR fell out of date with the lumi update, oops
ThatzOkay added 5 commits 2024-06-20 21:12:14 +00:00 
Reviewed-on: ThatzOkay/artemis#3
Reviewed-on: ThatzOkay/artemis#4
ThatzOkay commented 2024-06-20 22:28:37 +00:00
Author
Contributor
Copy Link

If there is no diva profile yet it shows No profile information found for this account. Just tested this on clean database

If there is no diva profile yet it shows No profile information found for this account. Just tested this on clean database
ThatzOkay commented 2024-06-20 22:35:18 +00:00
Author
Contributor
Copy Link

Newly cloned and setup also seems to work for me

Newly cloned and setup also seems to work for me
Hay1tsme commented 2024-06-22 02:02:46 +00:00
Owner
Copy Link

great! In that case, merging

great! In that case, merging
Hay1tsme merged commit 7aa3cf82f1 into develop 2024-06-22 02:03:03 +00:00
Hay1tsme referenced this issue from a commit 2024-06-22 02:03:06 +00:00
Diva front end (#150)
beerpsi referenced this issue from a commit 2024-06-22 17:49:57 +00:00
Diva front end (#150)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
aimedb

Issue relating to AimeDB

  
bug

Something is not working

  
chuni

Relates to Pre-new Chunithm

  
chusan

Relates to post-New Chunithm

  
cxb

Relates to Crossbeats

  
database

Relates to the database in general

  
diva

Relates to Project Diva

  
doc

Relates to documentation of Artemis

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Relates to the webui

  
help wanted

Need some help

  
idac

Relates to InitialD The Arcade

  
idz

Relates to InitialD Arcade Stage Zero

  
invalid

Something is wrong

  
maidx

Relates to Maimai DX

  
ongeki

Relates to Ongeki

  
pokken

Relates to Pokken

  
question

More information is needed

  
seen

This issue or PR has been seen

  
system

This issue or PR pertains to the overall system

  
testing

This issue or PR is ready for testing

  
wacca

Relates to Wacca

  
waiting

Waiting for issue reporter/PR author feedback

  
wip

This issue or PR is being worked on

  
wontfix

This won't be fixed

No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#150
No description provided.
Delete Branch "ThatzOkay/artemis:feature/diva-frontend"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?