Fix wrong id being used to check for Chunithm WORLD'S END charts #33
No reviewers
Labels
No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Hay1tsme/artemis#33
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ASleepyCat/artemis:fix-worlds-end-id"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Not sure if using the id of 4 was intentional, but it looks like WORLD'S END corresponds to id 5.
Fix wrong id being used to check for WORLD'S END chartsto Fix wrong id being used to check for WORLD'S END Chunithm chartsFix wrong id being used to check for WORLD'S END Chunithm chartsto Fix wrong id being used to check for Chunithm WORLD'S END charts098dbe4517
tob1074a6e0d
b1074a6e0d
to4c728a828a
4c728a828a
to72c48ba055
72c48ba055
to27ac224b9f
27ac224b9f
to0a0fdb6931
0a0fdb6931
to32d14777e3
Hello,
This cannot be approved as it is right now since Chunithm Paradise and older uses ID 4 for WORLD'S END.
You would need to tweak the code to do something like check if it says "WORLD'S END" in the data field and ID equals 5 or 4 to determine if the imported data is from New+ or Paradise or older.
32d14777e3
to438686fdeb
142cc21653
to438686fdeb
I didn't know that was the case, I've updated it so it should be correct now.
438686fdeb
to4a916cb4d1
That appears to now be good, i'll approve the merge
Thank you!