[chuni] Add correct endpoint iter_counts for all versions with encryption #151

beerpsi · 2024-06-12T09:11:14Z

beerpsi commented

2024-06-12 09:11:14 +00:00

Also add support for international encryption keys, closing #129

beerpsi added 1 commit 2024-06-12 09:11:14 +00:00

[chuni] Add correct endpoint iter_counts for all versions with encryption c3efc36be2

beerpsi added 1 commit 2024-06-15 15:22:48 +00:00

support SDGS encryption bf8631448a

Midorica commented

2024-06-16 16:32:07 +00:00

Regarding this pull request, could you modify the docs/game_specific_info.md to reflect the changes you just did so people knows how to assign the key, iv and hash for intl?

Also please add the change to the changelog

Thanks!

Regarding this pull request, could you modify the docs/game_specific_info.md to reflect the changes you just did so people knows how to assign the key, iv and hash for intl? Also please add the change to the changelog Thanks!

Hay1tsme added the

enhancement

chuni

waiting

labels 2024-06-17 15:24:52 +00:00

beerpsi added 1 commit 2024-06-18 02:39:28 +00:00

Add changelog and docs 243d40cfd8

beerpsi commented

2024-06-18 02:42:28 +00:00

Should be done. However, as discussed in Discord, there's still the problem of SUPER STAR (SDGS 1.00) and SUPER STAR+ (SDGS 1.05) being treated as the same internal version (VER_CHUNITHM_PARADISE), which makes assigning encryption keys difficult since they have different keys and salts. I'm open to suggestions on how to solve this. 9_int could be assigned to SUPER STAR and 10_int to SUPER STAR+, but that will add a bunch of checks and look fairly ugly.

Should be done. However, as discussed in Discord, there's still the problem of SUPER STAR (SDGS 1.00) and SUPER STAR+ (SDGS 1.05) being treated as the same internal version (`VER_CHUNITHM_PARADISE`), which makes assigning encryption keys difficult since they have different keys and salts. I'm open to suggestions on how to solve this. `9_int` could be assigned to SUPER STAR and `10_int` to SUPER STAR+, but that will add a bunch of checks and look fairly ugly.

Hay1tsme commented

2024-06-20 18:39:48 +00:00

This PR fell out of date with the lumi update, oops

Hay1tsme referenced this issue from a commit

2024-06-28 17:10:22 +00:00

Merge branch 'beerpsi-fix/chuni/correct-iter-counts' into develop (#151)

Hay1tsme commented

2024-06-28 17:11:47 +00:00

This PR is merged but gitea is dumb so it will mark it as "closed"

Hay1tsme closed this pull request

2024-06-28 17:11:47 +00:00