Dniel97/segatools
15
23
Fork 17
forked from Hay1tsme/segatools
Code Issues 3 Pull Requests 5 Actions Packages Releases 11 Wiki Activity

printer: Add setting to configure "printing time" #39

Merged
Dniel97 merged 3 commits from Haruka/segatools:printerdelay into develop 2024-10-04 12:53:27 +00:00
Conversation 3 Commits 3 Files Changed 4 +33 -8
Haruka commented 2024-10-03 10:19:17 +00:00
Contributor
Copy Link

I've noticed that on Kemono Friends 3 (yup that game again), some things can occur while a card is being printed, like a quiz thingy or something to interact with the character being printed.
Since the printer instantly finishes, I've added a configurable time delay (defaults to off / current behaviour), to simulate the printing process running for X ms with a new setting waitTime in [printer].

No docs exist for the printer settings, if needed I can add them.

Tested with FGO and KF3.

https://puu.sh/Kg6lc/0998a0afca.png

I've noticed that on Kemono Friends 3 (yup that game again), some things can occur while a card is being printed, like a quiz thingy or something to interact with the character being printed. Since the printer instantly finishes, I've added a configurable time delay (defaults to off / current behaviour), to simulate the printing process running for X ms with a new setting waitTime in [printer]. No docs exist for the printer settings, if needed I can add them. Tested with FGO and KF3. ![https://puu.sh/Kg6lc/0998a0afca.png](https://puu.sh/Kg6lc/0998a0afca.png)
Haruka added 2 commits 2024-10-03 10:19:18 +00:00
Dniel97 commented 2024-10-03 21:06:10 +00:00
Owner
Copy Link

Hey,

thanks again for the PR. How does this help Kemono 3 when the wait timer is set to 0 by default? ;)
Could you add the proper segatools.ini config to kemono so user can see and configure the wait time accordingly?

Hey, thanks again for the PR. How does this help Kemono 3 when the wait timer is set to 0 by default? ;) Could you add the proper segatools.ini config to kemono so user can see and configure the wait time accordingly?
Haruka added 1 commit 2024-10-04 09:43:50 +00:00
Haruka commented 2024-10-04 09:43:57 +00:00
Author
Contributor
Copy Link

Oh I just wanted to leave it at default since the amount of people that will actually care about this probably a single digit, but yeah actually making the setting visible makes sense lol.

Oh I just wanted to leave it at default since the amount of people that will actually care about this probably a single digit, but yeah actually making the setting visible makes sense lol.
Dniel97 commented 2024-10-04 12:53:19 +00:00
Owner
Copy Link

Perfect, thanks for updating. Seems fine to me!

Perfect, thanks for updating. Seems fine to me!
Dniel97 merged commit 8c24e04900 into develop 2024-10-04 12:53:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/segatools#39
No description provided.
Delete Branch "Haruka/segatools:printerdelay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?