Dniel97/segatools
15
23
Fork 18
forked from Hay1tsme/segatools
Code Issues 4 Pull Requests 5 Actions Packages Releases 11 Wiki Activity

add almost full vfd implementation #31

Merged
Dniel97 merged 5 commits from Haruka/segatools:vfd into develop 2024-08-24 21:56:40 +00:00
Conversation 3 Commits 5 Files Changed 15 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 824bc9abda - Show all commits

2
board/config.c
View File

@ -90,6 +90,6 @@ void vfd_config_load(struct vfd_config *cfg, const wchar_t *filename)
assert(filename != NULL);
cfg->enable = GetPrivateProfileIntW(L"vfd", L"enable", 1, filename);
cfg->port = GetPrivateProfileIntW(L"vfd", L"portNo", 1, filename);
cfg->port = GetPrivateProfileIntW(L"vfd", L"portNo", 0, filename);
Dniel97 marked this conversation as resolved Outdated
Dniel97 commented 2024-08-23 15:03:00 +00:00
Outdated
Review
Copy Link

Awesome PR, the only "issue" I have with it is that the portNo is set in each segatools.ini config. So my idea would be to set this to 0 by default and only read the portNo from segatools.ini if the portNo is not 0.

Awesome PR, the only "issue" I have with it is that the `portNo` is set in each segatools.ini config. So my idea would be to set this to 0 by default and only read the `portNo` from segatools.ini if the `portNo` is not 0.
cfg->utf_conversion = GetPrivateProfileIntW(L"vfd", L"utfConversion", 0, filename);
}