add almost full vfd implementation #31

Merged
Dniel97 merged 5 commits from Haruka/segatools:vfd into develop 2024-08-24 21:56:40 +00:00
Contributor

Like requested, here's a port of my VFD implementation for your segatools version.
Given that most of the commands serve no purpose other than actually displaying on that little display, there's not much logic past printing to the console.

Tested with FGO.

Not implemented are drawing images and creating character pixel-maps, but I don't think I've ever seen a game use that.

Like requested, here's a port of my VFD implementation for your segatools version. Given that most of the commands serve no purpose other than actually displaying on that little display, there's not much logic past printing to the console. Tested with FGO. Not implemented are drawing images and creating character pixel-maps, but I don't think I've ever seen a game use that. ![](https://puu.sh/KdvNI/5ad4b1c4ca.png)
Haruka added 1 commit 2024-08-23 14:34:43 +00:00
Dniel97 requested changes 2024-08-23 15:05:22 +00:00
Dismissed
board/config.c Outdated
@ -90,4 +90,6 @@ void vfd_config_load(struct vfd_config *cfg, const wchar_t *filename)
assert(filename != NULL);
cfg->enable = GetPrivateProfileIntW(L"vfd", L"enable", 1, filename);
cfg->port = GetPrivateProfileIntW(L"vfd", L"portNo", 1, filename);
Owner

Awesome PR, the only "issue" I have with it is that the portNo is set in each segatools.ini config. So my idea would be to set this to 0 by default and only read the portNo from segatools.ini if the portNo is not 0.

Awesome PR, the only "issue" I have with it is that the `portNo` is set in each segatools.ini config. So my idea would be to set this to 0 by default and only read the `portNo` from segatools.ini if the `portNo` is not 0.
Dniel97 marked this conversation as resolved
board/vfd.c Outdated
@ -39,1 +59,3 @@
uart_init(&vfd_uart, port_no);
utf_enabled = cfg->utf_conversion;
dprintf("VFD: enabling (port=%d)\n", cfg->port);
Owner

So instead of loading it from cfg->port everytime only load it from the segatools.ini file when its not 0.

So instead of loading it from `cfg->port` everytime only load it from the `segatools.ini` file when its not 0.
Dniel97 marked this conversation as resolved
Owner

Oh and please add the two new VFD config entries to doc/config/common.md.

Oh and please add the two new VFD config entries to [doc/config/common.md](https://gitea.tendokyu.moe/Dniel97/segatools/src/branch/develop/doc/config/common.md).
Haruka added 1 commit 2024-08-23 15:22:49 +00:00
Haruka added 1 commit 2024-08-23 15:24:10 +00:00
Haruka added 1 commit 2024-08-23 15:24:59 +00:00
Author
Contributor

should be everything as requested

should be everything as requested
Owner

Now the question is if the portNo in every segatools.ini is even required, Because on the one hand aime reader and led boards don't have that specified in the ini. But on the other hand I can understand that it's nice to have. Let me know what you think about removing the portNo from the configs.

Now the question is if the `portNo` in every segatools.ini is even required, Because on the one hand aime reader and led boards don't have that specified in the ini. But on the other hand I can understand that it's nice to have. Let me know what you think about removing the `portNo` from the configs.
Haruka added 1 commit 2024-08-24 09:14:32 +00:00
Dniel97 approved these changes 2024-08-24 21:56:24 +00:00
Dniel97 merged commit c827b4c212 into develop 2024-08-24 21:56:40 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/segatools#31
No description provided.