Dniel97/segatools
14
21
Fork 16
forked from Hay1tsme/segatools
Code Issues 3 Pull Requests 4 Actions Packages Releases 10 Wiki Activity

Add bounds checking for D3D9 adapter number #29

Merged
Dniel97 merged 1 commits from Bottersnike/segatools:fix/adapter_range into develop 2024-08-19 13:55:00 +00:00
Conversation 1 Commits 1 Files Changed 1 +12 -2
Bottersnike commented 2024-08-17 20:20:47 +00:00
Contributor
Copy Link

Currently, an invalid [gfx] monitor=... value will crash. This patch applies bounds checking.

As adapter is an unsigned integer, gfx_config.monitor being negative will still cause it to be larger than max_adaptor and hit the bounds check.

Currently, an invalid `[gfx] monitor=...` value will crash. This patch applies bounds checking. As `adapter` is an unsigned integer, `gfx_config.monitor` being negative will still cause it to be larger than `max_adaptor` and hit the bounds check.
Bottersnike added 1 commit 2024-08-17 20:20:49 +00:00
Dniel97 commented 2024-08-19 13:54:53 +00:00
Owner
Copy Link

Thanks for the PR! That is a nice quality of life improvmenet and will be merged!

Thanks for the PR! That is a nice quality of life improvmenet and will be merged!
Dniel97 merged commit 6a4cae1165 into develop 2024-08-19 13:55:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/segatools#29
No description provided.
Delete Branch "Bottersnike/segatools:fix/adapter_range"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?