Dniel97
/
segatools
forked from Hay1tsme/segatools
11
15
Fork 4
Code Issues Pull Requests Actions Packages Releases 6 Wiki Activity

Include chu2to3 engine #1

Merged
Dniel97 merged 1 commits from CrazyRedMachine/segatools:chuniio into chuniio 2023-12-25 14:02:34 +00:00
Conversation 1 Commits 1 Files Changed 11 +532 -37
CrazyRedMachine commented 2023-12-24 13:44:02 +00:00
Contributor
Copy Link

Seems to be working as expected :) merry christmas

path= will load chu2to3 engine to make a single 32bit dll work with chusan (should be compatible with chuni dlls and fufubot etc)

Note: chu2to3 engine has priority, so if you fill path=,path32= AND path64=, the latter 2 will be ignored

Note: new tower led functions for chuniio are technically noted as 0x0102 minimal api version, but due to the way symbols are loaded segatools won't complain if the functions are found in a 0x0101 or even a 0x0100 api dll.
(we should probably add a ".ver" field in struct dll_bind_sym and modify dll_bind() accordingly, but that would require changes to other game hooks as well)
chu2to3 engine will also always attempt to use them if they exist, to retain compatibility with fufubot dlls

Seems to be working as expected :) merry christmas path= will load chu2to3 engine to make a single 32bit dll work with chusan (should be compatible with chuni dlls and fufubot etc) Note: chu2to3 engine has priority, so if you fill path=,path32= AND path64=, the latter 2 will be ignored Note: new tower led functions for chuniio are technically noted as 0x0102 minimal api version, but due to the way symbols are loaded segatools won't complain if the functions are found in a 0x0101 or even a 0x0100 api dll. (we should probably add a ".ver" field in struct dll_bind_sym and modify dll_bind() accordingly, but that would require changes to other game hooks as well) chu2to3 engine will also always attempt to use them if they exist, to retain compatibility with fufubot dlls
CrazyRedMachine added 1 commit 2023-12-24 13:44:02 +00:00
Dniel97 commented 2023-12-25 14:02:30 +00:00
Owner
Copy Link

Thank you very much for the contribution!

I compiled and tested your commits and found just small bugs which fill be fixed in a commit soon after the merge. Everything worked as expected and I will merge the PR now :)

Thank you very much for the contribution! I compiled and tested your commits and found just small bugs which fill be fixed in a commit soon after the merge. Everything worked as expected and I will merge the PR now :)
Dniel97 merged commit 16bbd87c73 into chuniio 2023-12-25 14:02:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/segatools#1
No description provided.
Delete Branch "CrazyRedMachine/segatools:chuniio"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?