Fix Wrong Config #2

kwankaho · 2023-10-18T06:37:07Z

kwankaho commented

2023-10-18 06:37:07 +00:00

First-time contributor

\artemis\titles\idac\config.py

`
class IDACStampConfig:
def init(self, parent: "IDACConfig") -> None:
self.__config = parent

@property
def enable(self) -> bool:
    return CoreConfig.get_config_field(
        self.__config, "idac", "stamp", "enable", default=True
    )

`

\artemis\titles\idac\config.py ` class IDACStampConfig: def __init__(self, parent: "IDACConfig") -> None: self.__config = parent @property def enable(self) -> bool: return CoreConfig.get_config_field( self.__config, "idac", "stamp", "enable", default=True ) `

kwankaho added 1 commit 2023-10-18 06:37:08 +00:00

24dd677ccf Fix Wrong Config

kwankaho added 1 commit 2023-10-18 06:46:38 +00:00

f6036c8548 Fix Build Error

build need pkg-config
log folder no need(instead of logs)

kwankaho commented

2023-10-18 06:49:31 +00:00

First-time contributor

Docker build need pkg-config
log folder no need(instead of logs)

Docker build need pkg-config log folder no need(instead of logs)

Dniel97 commented

2023-10-18 14:47:59 +00:00

Oh thanks for the PR!

I also realized that f6036c8548/example_config/idac.yaml (L2) is wrong as well, so if you can also rename enabled to enable I will approve the PR asap. I think you should change ADD log log to ADD logs logs so Docker will add the logs directory as well.

Oh thanks for the PR! I also realized that https://gitea.tendokyu.moe/kwankaho/artemis/src/commit/f6036c8548b14a6fbd83a994e9993b7f6254d2fe/example_config/idac.yaml#L2 is wrong as well, so if you can also rename `enabled` to `enable` I will approve the PR asap. I think you should change `ADD log log` to `ADD logs logs` so Docker will add the logs directory as well.

kwankaho commented

2023-10-19 16:12:22 +00:00

First-time contributor

re

kwankaho closed this pull request

2023-10-19 16:12:22 +00:00

Dniel97 referenced this issue from a commit

2023-11-13 16:27:22 +00:00

add protobuf to requirements, fixes #2

Dniel97 referenced this issue from a commit

2024-03-12 17:33:14 +00:00

add protobuf to requirements, fixes #2