Dniel97
/
artemis
forked from Hay1tsme/artemis
8
7
Fork 4
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

online round events implenments #13

Open
UncleJim wants to merge 16 commits from UncleJim/artemis:idac_rounds_impl into idac
pull from: UncleJim/artemis:idac_rounds_impl
merge into: Dniel97:idac
Conversation 0 Commits 16 Files Changed 11 +1034 -111
UncleJim commented 2024-05-04 06:45:17 +00:00
Contributor
Copy Link
No description provided.
UncleJim added 12 commits 2024-05-04 06:45:19 +00:00
UncleJim added 2 commits 2024-05-07 04:30:11 +00:00
UncleJim added 1 commit 2024-05-07 06:50:45 +00:00
Dniel97 reviewed 2024-05-09 19:30:40 +00:00
titles/idac/schema/rounds.py Outdated
@ -0,0 +128,4 @@
tmp = {}
tmp["round_id_in_json"] = round_id
tmp["name"] = round_data["round_event_nm"]
tmp["season"] = 2 # default season 2
Dniel97 commented 2024-05-09 19:30:40 +00:00
Owner
Copy Link

Please don't hardcode the season and make it a default argument

Please don't hardcode the season and make it a default argument
Dniel97 reviewed 2024-05-09 19:33:18 +00:00
titles/idac/season2.py
@ -3029,0 +3173,4 @@
car["l_no"] = data.pop("l_no")
await self.data.item.put_car(user_id, self.version, car)
else:
data.pop("style_car_id")
Dniel97 commented 2024-05-09 19:33:18 +00:00
Owner
Copy Link

Always use pop and dont just pop it inside the if AND inside the else

Always use pop and dont just pop it inside the if AND inside the else
Dniel97 reviewed 2024-05-09 19:33:43 +00:00
.gitignore
@ -163,1 +162,4 @@
dbdump-*.json
/.vs
/titles/id8
Dniel97 commented 2024-05-09 19:33:43 +00:00
Owner
Copy Link

Is .gitignore really needed?

Is .gitignore really needed?
UncleJim commented 2024-05-10 03:14:14 +00:00
Author
Contributor
Copy Link

No

No
Dniel97 reviewed 2024-05-09 19:34:43 +00:00
titles/idac/config.py
@ -152,0 +166,4 @@
"idac",
"round_event",
"enabled_round",
default="S1R1",
Dniel97 commented 2024-05-09 19:34:43 +00:00
Owner
Copy Link

Does it also work with S1R10? I would prefer a zero padded round (maybe even season?)

Does it also work with S1R10? I would prefer a zero padded round (maybe even season?)
UncleJim commented 2024-05-10 03:05:23 +00:00
Author
Contributor
Copy Link

it will work with any name of the round json file, as long as the context is formated with keys what the game want. because the method only read round_event_id of the json file and self.version as identification of round event instead of prasing the name of it.

it will work with any name of the round json file, as long as the context is formated with keys what the game want. because the method only read `round_event_id` of the json file and `self.version` as identification of round event instead of prasing the name of it.
UncleJim added 1 commit 2024-05-10 03:12:32 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b UncleJim-idac_rounds_impl idac
git pull idac_rounds_impl

Step 2:

Merge the changes and update on Gitea.
git checkout idac
git merge --no-ff UncleJim-idac_rounds_impl
git push origin idac
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/artemis#13
No description provided.
Delete Branch "UncleJim/artemis:idac_rounds_impl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?