Dniel97/AQUA-to-ARTEMiS
5
6
Fork 2
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add support for maimai dx festival #1

Merged
Dniel97 merged 4 commits from xyqyear/AQUA-to-ARTEMiS:add-mai2-fes-support into main 2023-10-28 22:05:14 +00:00
Conversation 5 Commits 4 Files Changed 1 +392 -2
xyqyear commented 2023-10-20 04:38:59 +00:00
Contributor
Copy Link

Tested with a full single player game session, but not tested with two player or ranking. But they should work.

Tested with a full single player game session, but not tested with two player or ranking. But they should work.
xyqyear added 1 commit 2023-10-20 04:39:00 +00:00
xyqyear added 1 commit 2023-10-20 04:43:22 +00:00
xyqyear added 1 commit 2023-10-20 06:56:05 +00:00
Dniel97 commented 2023-10-21 15:17:31 +00:00
Owner
Copy Link

Hello and thanks for the PR!

I was just quickly looking over the code and saw the following section:

aqua_importer.py Line 756 in 4cad01035f
udemae = {

And was wondering if there is a reason you haven't converted the snake_case from aqua to ARTEMiS camelCase and made it manually. Will test your code the next view days and see if it works.

If you have some improvements, just add them to the PR.

Hello and thanks for the PR! I was just quickly looking over the code and saw the following section: https://gitea.tendokyu.moe/xyqyear/AQUA-to-ARTEMiS/src/commit/4cad01035f0a1844731ee079fecb9b4720ab76dd/aqua_importer.py#L756 And was wondering if there is a reason you haven't converted the `snake_case` from aqua to ARTEMiS `camelCase` and made it manually. Will test your code the next view days and see if it works. If you have some improvements, just add them to the PR.
xyqyear commented 2023-10-22 00:23:47 +00:00
Author
Contributor
Copy Link

Hello! There is no particular reason why I converted it manually and I could just use the same conversion as

aqua_importer.py Line 182 in 4cad01035f
k = inflection.camelize(k, uppercase_first_letter=False)
, I guess I was just in the headspace to convert manually at that particular time.

Hello! There is no particular reason why I converted it manually and I could just use the same conversion as https://gitea.tendokyu.moe/xyqyear/AQUA-to-ARTEMiS/src/commit/4cad01035f0a1844731ee079fecb9b4720ab76dd/aqua_importer.py#L182 , I guess I was just in the headspace to convert manually at that particular time.
Dniel97 commented 2023-10-26 09:45:20 +00:00
Owner
Copy Link

Hello sorry for the late replay, would it be possible to push a commit to use inflection to make the code a little bit more readable?

Hello sorry for the late replay, would it be possible to push a commit to use inflection to make the code a little bit more readable?
xyqyear added 1 commit 2023-10-27 08:36:34 +00:00
xyqyear commented 2023-10-27 08:37:19 +00:00
Author
Contributor
Copy Link

Hello sorry for the late replay, would it be possible to push a commit to use inflection to make the code a little bit more readable?

Done.

> Hello sorry for the late replay, would it be possible to push a commit to use inflection to make the code a little bit more readable? > Done.
Dniel97 commented 2023-10-28 22:05:10 +00:00
Owner
Copy Link

Thanks for the PR! Finally tested it and was able to confirm it works :)

Thanks for the PR! Finally tested it and was able to confirm it works :)
Dniel97 merged commit c586e438aa into main 2023-10-28 22:05:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/AQUA-to-ARTEMiS#1
No description provided.
Delete Branch "xyqyear/AQUA-to-ARTEMiS:add-mai2-fes-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?