From 26cf9aa4a751030907b175f3963e9f7e5afef300 Mon Sep 17 00:00:00 2001 From: Tau Date: Sat, 12 Jun 2021 12:55:49 -0400 Subject: [PATCH] Delete coin blocker exports from IO DLLs These never get called at the moment, so we have no way of guaranteeing that any existing implementations are even correct. If we do decide to start emulating the coin blocker then we will need to advance the API versions, which will (hopefully) force any third-party devs to test their coin blocker code before opting in. --- chunihook/chuni-dll.c | 3 --- chunihook/chuni-dll.h | 1 - chunihook/chunihook.def | 1 - chuniio/chuniio.c | 3 --- chuniio/chuniio.h | 5 ----- divahook/diva-dll.c | 3 --- divahook/diva-dll.h | 1 - divahook/divahook.def | 1 - divaio/divaio.c | 3 --- divaio/divaio.h | 6 ------ 10 files changed, 27 deletions(-) diff --git a/chunihook/chuni-dll.c b/chunihook/chuni-dll.c index 3750c86..24efa5c 100644 --- a/chunihook/chuni-dll.c +++ b/chunihook/chuni-dll.c @@ -18,9 +18,6 @@ const struct dll_bind_sym chuni_dll_syms[] = { }, { .sym = "chuni_io_jvs_read_coin_counter", .off = offsetof(struct chuni_dll, jvs_read_coin_counter), - }, { - .sym = "chuni_io_jvs_set_coin_blocker", - .off = offsetof(struct chuni_dll, jvs_set_coin_blocker), }, { .sym = "chuni_io_slider_init", .off = offsetof(struct chuni_dll, slider_init), diff --git a/chunihook/chuni-dll.h b/chunihook/chuni-dll.h index e4a24f8..ecd88ee 100644 --- a/chunihook/chuni-dll.h +++ b/chunihook/chuni-dll.h @@ -9,7 +9,6 @@ struct chuni_dll { HRESULT (*jvs_init)(void); void (*jvs_poll)(uint8_t *opbtn, uint8_t *beams); void (*jvs_read_coin_counter)(uint16_t *total); - void (*jvs_set_coin_blocker)(bool open); HRESULT (*slider_init)(void); void (*slider_start)(chuni_io_slider_callback_t callback); void (*slider_stop)(void); diff --git a/chunihook/chunihook.def b/chunihook/chunihook.def index 5b310a5..2a90ab6 100644 --- a/chunihook/chunihook.def +++ b/chunihook/chunihook.def @@ -16,7 +16,6 @@ EXPORTS chuni_io_jvs_init chuni_io_jvs_poll chuni_io_jvs_read_coin_counter - chuni_io_jvs_set_coin_blocker chuni_io_slider_init chuni_io_slider_set_leds chuni_io_slider_start diff --git a/chuniio/chuniio.c b/chuniio/chuniio.c index 8813e68..4fffe69 100644 --- a/chuniio/chuniio.c +++ b/chuniio/chuniio.c @@ -75,9 +75,6 @@ void chuni_io_jvs_poll(uint8_t *opbtn, uint8_t *beams) } } -void chuni_io_jvs_set_coin_blocker(bool open) -{} - HRESULT chuni_io_slider_init(void) { return S_OK; diff --git a/chuniio/chuniio.h b/chuniio/chuniio.h index 87e7e76..2a24600 100644 --- a/chuniio/chuniio.h +++ b/chuniio/chuniio.h @@ -68,11 +68,6 @@ void chuni_io_jvs_poll(uint8_t *opbtn, uint8_t *beams); void chuni_io_jvs_read_coin_counter(uint16_t *total); -/* Set the state of the coin blocker. Parameter is true if the blocker is - disengaged (i.e. coins can be inserted) and false if the blocker is engaged - (i.e. the coin slot should be physically blocked). */ - -void chuni_io_jvs_set_coin_blocker(bool open); /* Initialize touch slider emulation. This function will be called before any other chuni_io_slider_*() function calls. diff --git a/divahook/diva-dll.c b/divahook/diva-dll.c index c871dd9..2f5793e 100644 --- a/divahook/diva-dll.c +++ b/divahook/diva-dll.c @@ -18,9 +18,6 @@ const struct dll_bind_sym diva_dll_syms[] = { }, { .sym = "diva_io_jvs_read_coin_counter", .off = offsetof(struct diva_dll, jvs_read_coin_counter), - }, { - .sym = "diva_io_jvs_set_coin_blocker", - .off = offsetof(struct diva_dll, jvs_set_coin_blocker), }, { .sym = "diva_io_slider_init", .off = offsetof(struct diva_dll, slider_init), diff --git a/divahook/diva-dll.h b/divahook/diva-dll.h index fe78ff2..1e57947 100644 --- a/divahook/diva-dll.h +++ b/divahook/diva-dll.h @@ -9,7 +9,6 @@ struct diva_dll { HRESULT (*jvs_init)(void); void (*jvs_poll)(uint8_t *opbtn, uint8_t *beams); void (*jvs_read_coin_counter)(uint16_t *total); - void (*jvs_set_coin_blocker)(bool open); HRESULT (*slider_init)(void); void (*slider_start)(diva_io_slider_callback_t callback); void (*slider_stop)(void); diff --git a/divahook/divahook.def b/divahook/divahook.def index a8f5d10..d6a11d4 100644 --- a/divahook/divahook.def +++ b/divahook/divahook.def @@ -16,7 +16,6 @@ EXPORTS diva_io_jvs_init diva_io_jvs_poll diva_io_jvs_read_coin_counter - diva_io_jvs_set_coin_blocker diva_io_slider_init diva_io_slider_set_leds diva_io_slider_start diff --git a/divaio/divaio.c b/divaio/divaio.c index 7db2075..760e198 100644 --- a/divaio/divaio.c +++ b/divaio/divaio.c @@ -72,9 +72,6 @@ void diva_io_jvs_read_coin_counter(uint16_t *out) *out = diva_io_coins; } -void diva_io_jvs_set_coin_blocker(bool open) -{} - HRESULT diva_io_slider_init(void) { return S_OK; diff --git a/divaio/divaio.h b/divaio/divaio.h index 202704e..bac3627 100644 --- a/divaio/divaio.h +++ b/divaio/divaio.h @@ -47,12 +47,6 @@ void diva_io_jvs_poll(uint8_t *opbtn, uint8_t *gamebtn); void diva_io_jvs_read_coin_counter(uint16_t *out); -/* Set the state of the coin blocker. Parameter is true if the blocker is - disengaged (i.e. coins can be inserted) and false if the blocker is engaged - (i.e. the coin slot should be physically blocked). */ - -void diva_io_jvs_set_coin_blocker(bool open); - /* Initialize touch slider emulation. This function will be called before any other diva_io_slider_*() function calls.