Chunithm Importer for SUN failed to import Ultima levels #63

New Issue

Alexall · 2023-11-06T08:32:59Z

Alexall commented

2023-11-06 08:32:59 +00:00

Founded codes in titles\chuni\read.py, line 172 ↓

chart_id = MusicFumenData.find("type").find("id").text
if chart_id == "4":
    level = float(xml_root.find("starDifType").text)
    we_chara = (
        xml_root.find("worldsEndTagName")
                      .find("str")
                      .text
                )
else:
    level = float(
        f"{MusicFumenData.find('level').text}.{MusicFumenData.find('levelDecimal').text}"
    )
    we_chara = None

It looks like it specifics a different set of element tags for level searching

I've checked the XML files with music data and found whatever the chart id is, the element tag for levels is always <level></level> and <levelDecimal></levelDecimal>

Also, it seems chartId in the generated database is different from the XML files

From the XML files

4 -> ULTIMA
5 -> WORLD'S END

From database, according to Non-null fields of worldsEndTag:

4 -> WORLD'S END
5 -> ULTIMA

I only found starDifType elements in WORLD'S END, so is it wrongly coded with if chart_id == "4" while it should be "5"?

These are what I found in SUN but I don't know how they are in other versions

Founded codes in titles\chuni\read.py, line 172 ↓ ```py chart_id = MusicFumenData.find("type").find("id").text if chart_id == "4": level = float(xml_root.find("starDifType").text) we_chara = ( xml_root.find("worldsEndTagName") .find("str") .text ) else: level = float( f"{MusicFumenData.find('level').text}.{MusicFumenData.find('levelDecimal').text}" ) we_chara = None ``` It looks like it specifics a different set of element tags for level searching I've checked the XML files with music data and found whatever the chart id is, the element tag for levels is always `<level></level>` and `<levelDecimal></levelDecimal>` Also, it seems chartId in the generated database is different from the XML files From the XML files - 4 -> ULTIMA - 5 -> WORLD'S END From database, according to Non-null fields of `worldsEndTag`: - 4 -> WORLD'S END - 5 -> ULTIMA I only found `starDifType` elements in WORLD'S END, so is it wrongly coded with `if chart_id == "4"` while it should be `"5"`? These are what I found in SUN but I don't know how they are in other versions

Midorica commented

2023-11-06 15:19:25 +00:00

Hello,

The code for the reader was basically built with Chunithm Paradise in mind and not Sun which is why you saw the different id for them.

It would require to have a version check for if Chunithm New or + to look for the Ultima and World's End different ID otherwise, use the existing formatting already in place

Hello, The code for the reader was basically built with Chunithm Paradise in mind and not Sun which is why you saw the different id for them. It would require to have a version check for if Chunithm New or + to look for the Ultima and World's End different ID otherwise, use the existing formatting already in place

Hay1tsme added the

bug

label 2023-12-10 22:42:25 +00:00

Hay1tsme added the

chusan

wip

labels 2023-12-10 22:46:41 +00:00

Sign in to join this conversation.