Hay1tsme/artemis
25
47
Fork 38
Code Issues 5 Pull Requests 1 Packages Projects Releases Wiki Activity

[chuni] Auto stock tickets at login #170

Merged
Hay1tsme merged 8 commits from daydensteve/artemis:chuni_ticket_stock into develop 2024-09-13 18:12:33 +00:00
Conversation 3 Commits 8 Files Changed 5 +47 -13
daydensteve commented 2024-09-03 00:05:41 +00:00
Contributor
Copy Link

Changes to allow automatic stock/restock of specified tickets when users log into Chunithm. Convenient for anyone wanting to run with always-available tickets.

Changes to allow automatic stock/restock of specified tickets when users log into Chunithm. Convenient for anyone wanting to run with always-available tickets.
daydensteve added 8 commits 2024-09-03 00:05:42 +00:00
Hay1tsme commented 2024-09-05 14:52:45 +00:00
Owner
Copy Link

Looks good, has this been tested?

Looks good, has this been tested?
Hay1tsme added the
enhancement
chuni
waiting
 labels 2024-09-05 15:47:20 +00:00
daydensteve commented 2024-09-06 19:43:57 +00:00
Author
Contributor
Copy Link

Looks good, has this been tested?

Yes, but only on Luminous (2.22). Tested various number of ticket IDs (0, 1, 2) and varying ticket counts (1, 50, 99)

I'll note this doesn't have control over the ticket data itself so you can't go and force use of tickets that wouldn't be normally usable if already stocked. I could see how this would be misleading to someone who isn't familiar with the ticket xml

> Looks good, has this been tested? Yes, but only on Luminous (2.22). Tested various number of ticket IDs (0, 1, 2) and varying ticket counts (1, 50, 99) I'll note this doesn't have control over the ticket data itself so you can't go and force use of tickets that wouldn't be normally usable if already stocked. I could see how this would be misleading to someone who isn't familiar with the ticket xml
Hay1tsme commented 2024-09-13 18:12:15 +00:00
Owner
Copy Link

Got ya, in that case this looks good to merge

Got ya, in that case this looks good to merge
Hay1tsme merged commit 7ebd9bfb8a into develop 2024-09-13 18:12:33 +00:00
daydensteve deleted branch chuni_ticket_stock 2024-09-14 23:54:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
aimedb

Issue relating to AimeDB

  
bug

Something is not working

  
chuni

Relates to Pre-new Chunithm

  
chusan

Relates to post-New Chunithm

  
cxb

Relates to Crossbeats

  
database

Relates to the database in general

  
diva

Relates to Project Diva

  
doc

Relates to documentation of Artemis

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
frontend

Relates to the webui

  
help wanted

Need some help

  
idac

Relates to InitialD The Arcade

  
idz

Relates to InitialD Arcade Stage Zero

  
invalid

Something is wrong

  
maidx

Relates to Maimai DX

  
ongeki

Relates to Ongeki

  
pokken

Relates to Pokken

  
question

More information is needed

  
seen

This issue or PR has been seen

  
system

This issue or PR pertains to the overall system

  
testing

This issue or PR is ready for testing

  
wacca

Relates to Wacca

  
waiting

Waiting for issue reporter/PR author feedback

  
wip

This issue or PR is being worked on

  
wontfix

This won't be fixed

No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Hay1tsme/artemis#170
No description provided.
Delete Branch "daydensteve/artemis:chuni_ticket_stock"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?