Ongeki: Folder and overall clear counts don't save/display properly #146

New Issue

akanyan · 2024-05-26T20:09:12Z

akanyan commented

2024-05-26 20:09:12 +00:00

#127 described three problems and only one has been solved.

These are still broken on the latest develop:

The overall clear count (shown right above the song list, on the left, in a yellow tab).
Folder clear count (the x / xxx stat in each folder tab in-game). Note: Folder lamps (battle grade, tech grade, full bell, full combo/all break) do currently work.

The counters increment as you play the game but reset after a re-login.

#127 described three problems and only one has been solved. These are still broken on the latest `develop`: * The overall clear count (shown right above the song list, on the left, in a yellow tab). * Folder clear count (the x / xxx stat in each folder tab in-game). Note: Folder lamps (battle grade, tech grade, full bell, full combo/all break) do currently work. The counters increment as you play the game but reset after a re-login.

~~akanyan referenced this issue 2024-05-26 21:45:22 +00:00~~

ongeki: fix clearstatus type #147

akanyan commented

2024-05-26 21:52:16 +00:00

The game expects an int. With #147, clear counts do show up but they appear to be bollocks because it is possible to overwrite a clear with a non-clear. For example:

select clearStatus,overDamage from ongeki_score_playlog where musicId=830 and level=3 order by userPlayDate asc;

# Here, clearStatus=1 is a draw and clearStatus=2 is a win
clearStatus	overDamage
1	0
0	0
1	0
0	0
2	1493
1	0
1	0
1	0
1	0
1	0
1	0
1	0


select clearStatus from ongeki_score_best where musicId=830 and level=3;

# Here, clearStatus=1 is a win and clearStatus=0 is a loss/draw
clearStatus
0

~~put_best_score should upsert max(oldClearStatus, newClearStatus)~~ This was caused by the game being fed wrong data. After #147 and https://gitea.tendokyu.moe/akanyan/artemis-ongeki-fix-clear-status, everything works as it should.

The game expects an int. With #147, clear counts do show up but they appear to be bollocks because it is possible to overwrite a clear with a non-clear. For example: ``` select clearStatus,overDamage from ongeki_score_playlog where musicId=830 and level=3 order by userPlayDate asc; # Here, clearStatus=1 is a draw and clearStatus=2 is a win clearStatus overDamage 1 0 0 0 1 0 0 0 2 1493 1 0 1 0 1 0 1 0 1 0 1 0 1 0 select clearStatus from ongeki_score_best where musicId=830 and level=3; # Here, clearStatus=1 is a win and clearStatus=0 is a loss/draw clearStatus 0 ``` ~~`put_best_score` should upsert `max(oldClearStatus, newClearStatus)`~~ This was caused by the game being fed wrong data. After #147 and https://gitea.tendokyu.moe/akanyan/artemis-ongeki-fix-clear-status, everything works as it should.

akanyan referenced a pull request that will close this issue

2024-05-28 18:04:33 +00:00

ongeki: fix clearstatus type #147

Midorica closed this issue

2024-06-08 15:34:26 +00:00

Sign in to join this conversation.