Project diva arcade fututre tone gives Exception #143
Labels
No Label
aimedb
bug
chuni
chusan
cxb
database
diva
doc
duplicate
enhancement
frontend
help wanted
idac
idz
invalid
maidx
ongeki
pokken
question
seen
system
testing
wacca
waiting
wip
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Hay1tsme/artemis#143
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I thought id try to run project diva arcade hooking it up to artemis but every time i start the game up i got this exception in the logs
INFO: 192.168.192.33:33366 - "POST /DivaServlet/ HTTP/1.0" 500 Internal Server Error
ERROR: Exception in ASGI application
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/uvicorn/protocols/http/h11_impl.py", line 407, in run_asgi
result = await app( # type: ignore[func-returns-value]
File "/usr/local/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 69, in call
return await self.app(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/applications.py", line 123, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 186, in call
raise exc
File "/usr/local/lib/python3.9/site-packages/starlette/middleware/errors.py", line 164, in call
await self.app(scope, receive, _send)
File "/usr/local/lib/python3.9/site-packages/starlette/middleware/exceptions.py", line 65, in call
await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
raise exc
File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 756, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 776, in app
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 297, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 77, in app
await wrap_app_handling_exceptions(app, request)(scope, receive, send)
File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
raise exc
File "/usr/local/lib/python3.9/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/lib/python3.9/site-packages/starlette/routing.py", line 72, in app
response = await func(request)
TypeError: render_POST() missing 2 required positional arguments: 'game_code' and 'matchers'
diva was untested on the develop branch so this doesn't come as a surprise
line 82 in titles/diva/index.py , put this
async def render_POST(self, request: Request) -> bytes:instead of
async def render_POST(self, request: Request, game_code: str, matchers: Dict) -> bytes:let me know how that goes afterward
issue should be fixed under the last commit
0a408baa87yeah nice. I now get this artemis message so i guess it is working
Okay i have no succesfully registred but now after clicking start a new error arises: Error handling method handle_start_request 'coroutine' object is not iterable
[2024-05-23 22:04:57] Diva | DEBUG | {'cmd': 'start', 'req_id': '00000000TEmrO049', 'game_id': 'SBZV', 'r_ver': '7.10.00', 'kc_serial': 'A69E01A8888', 'b_serial': 'AAVE01A9999', 'place_id': '0123', 'time_stamp': '2024-05-24T07:04:57+09:00', 'start_up_mode': '1', 'cmm_dly_mod': '0', 'cmm_dly_sec': '0', 'cmm_err_mod': '0', 'country_code': 'JPN', 'region_code': '1', 'pd_id': '1', 'accept_idx': '100'}
[2024-05-23 22:04:57] Diva | ERROR | Error handling method handle_start_request 'coroutine' object is not iterable
INFO: 192.168.192.115:53860 - "POST /DivaServlet/ HTTP/1.0" 200 OK
[2024-05-23 22:04:57] Diva | INFO | pd_unlock Request
[2024-05-23 22:04:57] Diva | DEBUG | {'cmd': 'pd_unlock', 'req_id': '00000000mEmrO04a', 'game_id': 'SBZV', 'r_ver': '7.10.00', 'kc_serial': 'A69E01A8888', 'b_serial': 'AAVE01A9999', 'place_id': '0123', 'time_stamp': '2024-05-24T07:04:58+09:00', 'start_up_mode': '1', 'cmm_dly_mod': '0', 'cmm_dly_sec': '0', 'cmm_err_mod': '0', 'country_code': 'JPN', 'region_code': '1', 'pd_id': '1', 'accept_idx': '100'}
[2024-05-23 22:04:57] Diva | DEBUG | Response cmd=pd_unlock&req_id=00000000mEmrO04a&stat=ok
INFO: 192.168.192.115:53861 - "POST /DivaServlet/ HTTP/1.0" 200 OK
I'll leave that fix for someone else, it is an await missing somewhere in the handle_start_request most likely but i can't see to find which one exactly
i personally do not use the develop branch at this time so i can't do testing
Do you maybe have an idea where it could be i could try to make myself a pr
one member in the discord pushed a fix, you can find it in the new commit here :
a5fd6e65d6Thanks I'll test out tommorow
also found the missing awaits.
#145
alright i have merged the PR you did for the missing awaits , thank you for testing!