Dniel97
/
AQUA-to-ARTEMiS
4
4
Fork 2
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Add MySQL support #2

Merged
Dniel97 merged 2 commits from Floatin/AQUA-to-ARTEMiS:mysql-support into main 2023-10-28 21:50:55 +00:00
Conversation 3 Commits 2 Files Changed 1 +53 -21
Floatin commented 2023-10-20 07:26:47 +00:00
Contributor
Copy Link
No description provided.
Floatin added 1 commit 2023-10-20 07:26:48 +00:00
Dniel97 commented 2023-10-21 15:12:32 +00:00
Owner
Copy Link

Hello, thanks for the PR!

I was thinking about adding MySQL support as well and I think it would be even easier to load the application.properties file from aqua directly instead of manually entering the database connection credentials in the command line. Maybe you can think of a way to parse the application.properties or maybe simplify the database/password input.

Let me know what you think!

Hello, thanks for the PR! I was thinking about adding MySQL support as well and I think it would be even easier to load the application.properties file from aqua directly instead of manually entering the database connection credentials in the command line. Maybe you can think of a way to parse the application.properties or maybe simplify the database/password input. Let me know what you think!
Floatin added 1 commit 2023-10-22 09:28:36 +00:00
Floatin commented 2023-10-22 09:30:17 +00:00
Author
Contributor
Copy Link

Done!

Not tested in depth, but it should work as expected.

Done! Not tested in depth, but it should work as expected.
Dniel97 commented 2023-10-28 21:50:50 +00:00
Owner
Copy Link

You are missing self.use_mysql = False inside the Importer class, but thats fine, will fix it real quick! Thanks for the PR!

You are missing `self.use_mysql = False` inside the Importer class, but thats fine, will fix it real quick! Thanks for the PR!
Dniel97 merged commit 4b7cde6dfb into main 2023-10-28 21:50:55 +00:00
Floatin deleted branch mysql-support 2023-12-23 15:14:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Dniel97/AQUA-to-ARTEMiS#2
No description provided.
Delete Branch "Floatin/AQUA-to-ARTEMiS:mysql-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?